Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added arrows to scroll between images #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QyuBee
Copy link

@QyuBee QyuBee commented Oct 2, 2024

Add navigation arrows for image carousel

Description

In order to enhance user experience when navigating between images of a monument, I have added two arrow icons for easier navigation. These icons are linked to the prevImage() and nextImage() functions. Previously, these functions were only accessible via the keyboard's "left arrow" and "right arrow" keys, which might not have been intuitive for new visitors.

Changes

  • Added two arrow icons for navigation between images.
  • Linked the arrow icons to the existing prevImage() and nextImage() functions.
  • Implemented a new activate_scroll parameter in the openImage function, allowing the arrows to only appear if there are multiple images available. This ensures that the navigation arrows are only displayed when useful.

Screenshot

Here is a screenshot of the added arrow icons:
image

Impact

  • More intuitive navigation for users, especially for those unfamiliar with keyboard shortcuts.
  • The arrows will only be visible when there are multiple images, avoiding unnecessary clutter.

I hope this feature proves helpful in improving the user experience.

@mahmoud
Copy link
Member

mahmoud commented Oct 16, 2024

Hey @QyuBee that's great! For the record, Monumental is in a deprecated state due to being unable to find a maintainer. It seems you're comfortable enough with the code to modify it, and have been able to get it building, which is more than I can say for myself. If you're interested in continuing to use it, I'll just be forward and ask: would you be interested in taking over maintainership? I'm happy to help with deployment. For clarity, even if I merge this, I don't have an environment where I can build it in order to deploy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants