Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile updates for traject #53

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Dockerfile updates for traject #53

merged 2 commits into from
Nov 1, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Oct 29, 2024

Brings our dockerfile up to current standards & allows building an image we can use in kubernetes for catalog indexing

  • remove wait-for & use health checks
  • use production stage

@aelkiss
Dockerfile updates for traject
b8ea52e 
* remove wait-for & use health checks
* use production stage
@aelkiss aelkiss requested a review from moseshll October 29, 2024 20:48
@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Coverage Status

coverage: 92.548%. remained the same
when pulling c346d78 on remove-wait-for
into d761182 on main.

Ronster2018
Ronster2018 reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Ronster2018 Ronster2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and make sense to me.

moseshll
moseshll approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@moseshll moseshll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests good. I commented on the collection code file, no resolution to that will be perfect.

@moseshll
- Regenerate `lib/translation_maps/ht/collection_code_to_original_fro…
c346d78 
…m.yaml` from production DB.

- Add `git update-index --skip-worktree` suggestion for this file to README.
@moseshll moseshll merged commit 6ad5b30 into main Nov 1, 2024
1 check passed
@moseshll moseshll deleted the remove-wait-for branch November 1, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moseshll moseshll moseshll approved these changes

@Ronster2018 Ronster2018 Ronster2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aelkiss @coveralls @Ronster2018 @moseshll