Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New section with Schema Diff #527

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

New section with Schema Diff #527

wants to merge 18 commits into from

Conversation

soorajshankar
Copy link
Member

@soorajshankar soorajshankar commented Jul 31, 2024

Description

This PR introduces a new section called Builds similar to the new section in console. The idea of this section is to have a home for the following questions

  • Where do I see the supergraph builds?
  • Where do I see the connector builds?
  • ... subgraph builds?

(Around Schema diff )

  • What is the ideal process of applying a build? can I see the impact beforehand?
  • What would schema-diff would do?
  • What happens if I apply this build?

Checklist

  • Validate the new section name before we merge this
  • Should we add sections Supergraph Builds & Connector Builds along with this PR?

Quick Links 🚀

🤖 DX: Assertion Tests

@robertjdominguez robertjdominguez self-requested a review July 31, 2024 09:58
@robertjdominguez
Copy link
Collaborator

Hey, @soorajshankar 👋

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer 🎉

Before Rob looks over the changes, we ask you to take care of a couple of items:

  • Make sure you've checked over our PR guide on the wiki. It ensures you've done your due diligence on the basics: spelling, heading casings, etc.
  • Rob will need a review from someone on your team to ensure your team-specific content is accurate. Once that's done, ping Rob on Slack, and he'll give a docs review 🔥
  • Additionally, please check this box to confirm your feature works as expected when using the documentation you've written. This is critical to ensuring our users have the information they need.

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack 👍

@robertjdominguez
Copy link
Collaborator

robertjdominguez commented Jul 31, 2024

DX: Assertion Testing

✅ Diff

The PR introduces coherent and clearly structured documentation for the API Change Management features. All markdown files have consistent header metadata and descriptions, which will help users navigate and understand the content easily. However, the connector-builds.mdx document's Content Time information seems incomplete. Please ensure that the details are appropriately formatted and complete.

✅ Integrated

The documentation PR appears to integrate well with the current documentation structure. The addition of the API Change Management category with corresponding icons enhances the navigation experience for the end user. Including real-life examples of schema changes within the context of Hasura DDN's functionality provides actionable insights for the users. The navigation path is maintained consistently (sidebar_pathname), ensuring a coherent user journey through the new documentation pages. However, please double-check the links in the overview cards, especially for 'Connector Builds', ensuring that they point to the correct paths.

@robertjdominguez
Copy link
Collaborator

Images automagically compressed by Calibre's image-actions

Compression reduced images by 33.9%, saving 84.13 KB.

Filename Before After Improvement Visual comparison
static/img/schema-diff/0.0.1_console_schema_diff_subview.png 89.88 KB 60.25 KB -33.0% View diff
static/img/schema-diff/0.0.1_console_schema_diff.png 158.19 KB 103.69 KB -34.5% View diff

153 images did not require optimisation.

Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2024

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9881f8
Status: ✅  Deploy successful!
Preview URL: https://343d1798.v3-docs-eny.pages.dev
Branch Preview URL: https://schema-diff.v3-docs-eny.pages.dev

View logs

@robertjdominguez
Copy link
Collaborator

Images automagically compressed by Calibre's image-actions

Compression reduced images by 32.3%, saving 68.18 KB.

Filename Before After Improvement Visual comparison
static/img/schema-diff/0.0.1_console_schema_diff.png 210.82 KB 142.64 KB -32.3% View diff

154 images did not require optimisation.

@soorajshankar soorajshankar marked this pull request as ready for review August 7, 2024 11:37
@soorajshankar soorajshankar changed the title schema diff WIP New section with Schema Diff Aug 7, 2024
@robertjdominguez
Copy link
Collaborator

Images automagically compressed by Calibre's image-actions

Compression reduced images by 37%, saving 39.93 KB.

Filename Before After Improvement Visual comparison
static/img/supergraph-builds/0.0.1_console_supergraph_builds.png 107.96 KB 68.03 KB -37.0% View diff

155 images did not require optimisation.

@robertjdominguez
Copy link
Collaborator

@soorajshankar — thanks for this!

After taking a look at the contents, I have clearer thoughts on how we should move forward with this. I'm struggling to see this as a dedicated top-level section, unless you folks + product think it's critical to highlight this in the sidebar.

Please let me know your thoughts to this idea:

  • We have a section called Project Configuration that has a page called Builds
  • I propose we modify this section's name to Project Management
  • We take the content for Manage * Build and move them to the Builds page
  • We reformat things a bit to cover lifecycles for a * build
  • We move the CLI steps front-and-center and the means of accessing them via the console down on the page (i.e., frontload CLI steps with console as a backup)

Again, all of this is predicated on what product wants. If the desire is to make this top-level, then I think we follow a similar format to the change suggested above:

  • Nuke the builds page in Project Configuration
  • We reformat things a bit to cover lifecycles for a * build
  • We move the CLI steps front-and-center and the means of accessing them via the console down on the page (i.e., frontload CLI steps with console as a backup)

@soorajshankar
Copy link
Member Author

soorajshankar commented Aug 12, 2024

We have a section called Project Configuration that has a page called Builds

I had a chat with Manushi, Rikin and Console team, and we shared the same sentiment that lets keep it Build Management for now and once we have more Project Configuration features may be lets reconsider this, wdyt?

Update: Ahh I see the Project Configuration section is already there, let me see how we can refactor then

@seanparkross seanparkross requested review from seanparkross and removed request for robertjdominguez August 12, 2024 08:50
@robertjdominguez
Copy link
Collaborator

We have a section called Project Configuration that has a page called Builds

I had a chat with Manushi, Rikin and Console team, and we shared the same sentiment that lets keep it Build Management for now and once we have more Project Configuration features may be lets reconsider this, wdyt?

Update: Ahh I see the Project Configuration section is already there, let me see how we can refactor then

Cool 👍

I'll let you and @seanparkross carry this forward. He's taking over shepherding this starting with our new sprint today.

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 35.9%, saving 37.80 KB.

Filename Before After Improvement Visual comparison
static/img/supergraph-builds/0.0.1_console_supergraph_builds.png 105.27 KB 67.47 KB -35.9% View diff

180 images did not require optimisation.

Copy link
Collaborator

@seanparkross seanparkross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it has taken so long. This one totally fell off the radar. Back on now! Couple comments and we should be good to go

docs/api-change-management/overview.mdx Outdated Show resolved Hide resolved
Comment on lines +41 to +45
<p>
A Supergraph is typically composed of multiple subgraphs, each potentially managed by different teams or services.
These subgraphs may, in turn, consist of one or more connectors. This hierarchical structure means that changes at the
connector or subgraph level can impact the overall Supergraph.
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we could leave this bit out because we're in the overview / introduction section and the other parts do a great intro job without this.

Suggested change
<p>
A Supergraph is typically composed of multiple subgraphs, each potentially managed by different teams or services.
These subgraphs may, in turn, consist of one or more connectors. This hierarchical structure means that changes at the
connector or subgraph level can impact the overall Supergraph.
</p>

4. Select the `Connector Builds` tab.
5. You'll see a table listing all your Connector builds.

<Thumbnail src="/img/supergraph-builds/0.0.1_console_supergraph_builds.png" alt="Supergraph Builds" width="700px" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is of supergraph not connector builds

@seanparkross
Copy link
Collaborator

One other question possibly not related to this PR... why is there nowhere to see subgraph builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants