-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section with Schema Diff #527
base: main
Are you sure you want to change the base?
Conversation
Hey, @soorajshankar 👋 Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer 🎉 Before Rob looks over the changes, we ask you to take care of a couple of items:
The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack 👍 |
DX: Assertion Testing✅ DiffThe PR introduces coherent and clearly structured documentation for the API Change Management features. All markdown files have consistent header metadata and descriptions, which will help users navigate and understand the content easily. However, the ✅ IntegratedThe documentation PR appears to integrate well with the current documentation structure. The addition of the API Change Management category with corresponding icons enhances the navigation experience for the end user. Including real-life examples of schema changes within the context of Hasura DDN's functionality provides actionable insights for the users. The navigation path is maintained consistently (sidebar_pathname), ensuring a coherent user journey through the new documentation pages. However, please double-check the links in the overview cards, especially for 'Connector Builds', ensuring that they point to the correct paths. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 33.9%, saving 84.13 KB.
153 images did not require optimisation. |
Deploying v3-docs with Cloudflare Pages
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 32.3%, saving 68.18 KB.
154 images did not require optimisation. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 37%, saving 39.93 KB.
155 images did not require optimisation. |
@soorajshankar — thanks for this! After taking a look at the contents, I have clearer thoughts on how we should move forward with this. I'm struggling to see this as a dedicated top-level section, unless you folks + product think it's critical to highlight this in the sidebar. Please let me know your thoughts to this idea:
Again, all of this is predicated on what product wants. If the desire is to make this top-level, then I think we follow a similar format to the change suggested above:
|
I had a chat with Manushi, Rikin and Console team, and we shared the same sentiment that lets keep it Build Management for now and once we have more Project Configuration features may be lets reconsider this, wdyt? Update: Ahh I see the Project Configuration section is already there, let me see how we can refactor then |
Cool 👍 I'll let you and @seanparkross carry this forward. He's taking over shepherding this starting with our new sprint today. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 35.9%, saving 37.80 KB.
180 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it has taken so long. This one totally fell off the radar. Back on now! Couple comments and we should be good to go
<p> | ||
A Supergraph is typically composed of multiple subgraphs, each potentially managed by different teams or services. | ||
These subgraphs may, in turn, consist of one or more connectors. This hierarchical structure means that changes at the | ||
connector or subgraph level can impact the overall Supergraph. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we could leave this bit out because we're in the overview / introduction section and the other parts do a great intro job without this.
<p> | |
A Supergraph is typically composed of multiple subgraphs, each potentially managed by different teams or services. | |
These subgraphs may, in turn, consist of one or more connectors. This hierarchical structure means that changes at the | |
connector or subgraph level can impact the overall Supergraph. | |
</p> |
4. Select the `Connector Builds` tab. | ||
5. You'll see a table listing all your Connector builds. | ||
|
||
<Thumbnail src="/img/supergraph-builds/0.0.1_console_supergraph_builds.png" alt="Supergraph Builds" width="700px" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is of supergraph not connector builds
One other question possibly not related to this PR... why is there nowhere to see subgraph builds? |
Co-authored-by: Sean Park-Ross <[email protected]>
Description
This PR introduces a new section called
Builds
similar to the new section in console. The idea of this section is to have a home for the following questions(Around Schema diff )
Checklist
Quick Links 🚀
🤖 DX: Assertion Tests