Escape single quote (') characters as ' #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports the upstream change made to `stache` in stackbuilders/stache#36. This fix is necessary to solve a `criterion` bug (haskell/criterion#202) in which single quotes are not escaped when substituted into `criterion`'s HTML template, causing browsers to display the report's contents incorrectly.
|
There's mustache/spec#69
- var ylabels = [{{#report}}[-{{number}},'<a href="#b{{number}}">{{name}}</a>'],{{/report}}]
+ var ylabels = [{{#report}}[-{{number}},"<a href=\"#b{{number}}\">{{name}}</a>"],{{/report}}]Additionally, I'm open to adding |
|
Bah, I was afraid that something in the mustache specification would get in the way. (I even charged ahead and changed In that case, I think your suggested fix of simply using double quotes instead of single quotes is the cleanest one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the upstream change made to
stachein stackbuilders/stache#36. This fix is necessary to solve acriterionbug (haskell/criterion#202) in which single quotes are not escaped when substituted intocriterion's HTML template, causing browsers to display the report's contents incorrectly.