Fix test compatibility with tar 0.5.* #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GenEntry` method was added in tar-0.6.0.0 and thus building hackage-security with tar 0.5.* fails with the following errors:
```
[8 of 8] Compiling Main ( tests/TestSuite.hs, dist/build/TestSuite/TestSuite-tmp/Main.dyn_o )
tests/TestSuite.hs:267:22: error:
Not in scope: type constructor or class ‘Tar.GenEntry’
Perhaps you meant ‘Tar.Entry’ (imported from Codec.Archive.Tar.Entry)
Module ‘Codec.Archive.Tar.Entry’ does not export ‘GenEntry’.
|
267 | testEntries1 :: [Tar.GenEntry Tar.TarPath linkTarget]
| ^^^^^^^^^^^^
```
|
Mmh, maybe we need to diversify our CI to test with older package versions. E.g. use |
andreasabel
added
re: testsuite
Merged
|
Do you need a release @felixonmars ? |
|
I have patched the Arch build, but it would be helpful for others I think :) |
andreasabel
referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenEntrymethod was added in tar-0.6.0.0 and thus building hackage-security with tar 0.5.* fails with the following errors: