Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cabal and Cabal-syntax to allow 3.12 #309

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

ffaf1
Copy link
Contributor

@ffaf1 ffaf1 commented Mar 18, 2024

I have tested the change by building all against Cabal and Cabal-syntax 3.12.

@ffaf1 ffaf1 marked this pull request as draft March 18, 2024 19:01
@ffaf1
Copy link
Contributor Author

ffaf1 commented Mar 18, 2024

I have bumped anything that was preventing cabal build all && cabal test all to work.
This is slightly more than what strictly needed to get Cabal 3.12 released but I think those bumps are reasonable and will be due anyway.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about bumping to < 3.14 so that the new dev cabal on master can build without allow-newer?

@ffaf1 ffaf1 marked this pull request as ready for review March 18, 2024 19:20
I have tested the change by building `all` against `Cabal` and
`Cabal-syntax` 3.12.
@andreasabel
Copy link
Member

andreasabel commented Mar 18, 2024

Does this PR make sense already when Cabal-3.12 isn't available yet and so CI cannot pick it up?

P.S.: Unfortunately, the workflows here do not contain an invocation of cabal plan so one cannot even see which version of which package was picked up. (Apologies, looked at the wrong workflow.)

https://github.com/haskell/hackage-security/actions/runs/8332470663/job/22801675832?pr=309#step:15:894

Cabal-syntax-3.10.2.0

@Mikolaj
Copy link
Member

Mikolaj commented Mar 18, 2024

Unfortunately we have the chicken and egg problem. In general, cabal can't be made available until hackage-security with permissive bounds is on Hackage, because cabal depends on hackage-security.

@ffaf1
Copy link
Contributor Author

ffaf1 commented Mar 18, 2024

Yep. See #291 (date: February 2023) too, where Cabal-syntax was bumped to < 3.12 before Cabal syntax 3.10.* was out (March 2023).

This Ouroboros is caused by bootstrap.py and I wonder if there is a way to unbundle it from Cabal release (alternatively: bundle whatever is needed from hackage-security into cabal)

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj Mikolaj merged commit 8f6b383 into haskell:master Mar 19, 2024
18 checks passed
@andreasabel andreasabel added this to the 0.6.2.5 milestone Mar 19, 2024
@andreasabel
Copy link
Member

@Mikolaj @ffaf1 hackage-security 0.6.2.5 has been released. Do you need a release of the hackage-repo-tool as well?

@ffaf1
Copy link
Contributor Author

ffaf1 commented Mar 20, 2024

It should not be needed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants