Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for GHC 7 and ancient versions of directory and time #304

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Drop support for GHC 7 and ancient versions of directory and time #304

merged 5 commits into from
Jan 9, 2024

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jan 9, 2024 •
edited
Loading

Towards

These commits have been individually verified by CI, so please preserve.

  • Require GHC 8 and base >= 4.9 (released 2016-05-21)
  • Require time >= 1.5 (released 2014-09-10)
  • Require directory >= 1.2.2 (released 2015-03-18)

@andreasabel
Require base >= 4.8, drop custom preludes
fd748e2 
The custom preludes simulated the Prelude of base-4.8, which is now
present always; thus, they are obsolete.
@andreasabel
Drop CPP conditional obsolete with base >= 4.8 (GHC 7.10)
a513156
@andreasabel andreasabel changed the title Require base >= 4.8, drop custom preludes Drop support for GHC 7 and ancient versions of directory and time Jan 9, 2024
@andreasabel andreasabel added the pr: preserve commits Merge the individual commits of this PR (rather than squashing) label Jan 9, 2024
@andreasabel andreasabel marked this pull request as ready for review January 9, 2024 06:50
@andreasabel andreasabel requested a review from Mikolaj January 9, 2024 06:50
Mikolaj
Mikolaj approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a huge cleanup. LGTM.

@andreasabel andreasabel self-assigned this Jan 9, 2024
@andreasabel
Copy link
Member Author

Well, it was basically grepping for #if and then going along. Bridging a couple of sleepless hours...

@andreasabel andreasabel merged commit 1a9764c into master Jan 9, 2024
20 checks passed
@andreasabel andreasabel deleted the drop-ghc-7 branch January 9, 2024 16:06
@andreasabel andreasabel mentioned this pull request Jan 9, 2024
Closed
@andreasabel andreasabel added this to the 0.6.2.5 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees

@andreasabel andreasabel

Labels
pr: preserve commits Merge the individual commits of this PR (rather than squashing)
Projects
None yet
Milestone
0.6.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasabel @Mikolaj