Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump stack all versions #94

Closed
wants to merge 6 commits into from
Closed

Conversation

jappeace
Copy link

@jappeace jappeace commented Dec 21, 2022

This modifies the stack install script to be installed on all architectures (although it still likely will fail on sha, but I intend to get those from the error message).
The stack install script has also been moved outside of the docker file for easier future edits. (hence the large amount of deletions).

this also adds support for debian aarch64, solving #59

@jappeace jappeace marked this pull request as draft December 21, 2022 11:57
@jappeace jappeace marked this pull request as ready for review December 21, 2022 16:45
@jappeace jappeace changed the title bump stack 8.10 bump stack all versions Dec 21, 2022
@jappeace jappeace mentioned this pull request Dec 21, 2022
Comment on lines +10 to +12
'aarch64')
STACK_SHA256='0581cebe880b8ed47556ee73d8bbb9d602b5b82e38f89f6aa53acaec37e7760d';
;;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be mentioned somewhere, let it be the title or the description

Copy link
Author

@jappeace jappeace Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I added that in the description, this sha is a lie, it'll likely break the script, I need ci to tell me what this is.

@AlistairB
Copy link
Contributor

Thanks!

My suggestion would be to not rewrite how the images work until you understand and are comfortable with the current pattern. For example, the directory structure exists as that is how the official images reference the dockerfiles for different GHC versions.

In terms of separate install scripts.. I don't know why not.. but this is not really done in any of the official images. The current install pattern pretty much mirrors all the official images. I suppose for one you are forced to have an image layer with the install script sticking around which is not valuable to the end user. You could create an issue on the official images repo asking them about the pros and cons of the install script being copied in solution.

If you want to fix the duplication problem, I think like the go official images the right solution is to use templating.
In general, we should following the patterns from the other official images which have been developed by very knowledge people, unless we have a good reason.

In terms of the shas, the dockerfiles have a comments like # sha256 from https://github.com/commercialhaskell/stack/releases/download/v${STACK}/stack-${STACK}-linux-$ARCH.tar.gz.sha256 telling you where to get them. Still, this is clearly not obvious enough. I'll spend some time on the weekend making sure this info is clear in the README.

So yeah, I suggest just doing the minimum to bump stack for now without other changes. If you want to do bigger changes that could go in a separate PR. Or feel free to create an issue.

@AlistairB
Copy link
Contributor

Oh and the GPG release key for stack never changes. I'll try and incorporate this better into the docs.

@AlistairB
Copy link
Contributor

I have gone ahead and done this bump. See #72 (comment) for details.

@AlistairB AlistairB closed this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants