-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump stack all versions #94
Conversation
'aarch64') | ||
STACK_SHA256='0581cebe880b8ed47556ee73d8bbb9d602b5b82e38f89f6aa53acaec37e7760d'; | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be mentioned somewhere, let it be the title or the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I added that in the description, this sha is a lie, it'll likely break the script, I need ci to tell me what this is.
Thanks! My suggestion would be to not rewrite how the images work until you understand and are comfortable with the current pattern. For example, the directory structure exists as that is how the official images reference the dockerfiles for different GHC versions. In terms of separate install scripts.. I don't know why not.. but this is not really done in any of the official images. The current install pattern pretty much mirrors all the official images. I suppose for one you are forced to have an image layer with the install script sticking around which is not valuable to the end user. You could create an issue on the official images repo asking them about the pros and cons of the install script being copied in solution. If you want to fix the duplication problem, I think like the go official images the right solution is to use templating. In terms of the shas, the dockerfiles have a comments like So yeah, I suggest just doing the minimum to bump stack for now without other changes. If you want to do bigger changes that could go in a separate PR. Or feel free to create an issue. |
Oh and the GPG release key for stack never changes. I'll try and incorporate this better into the docs. |
I have gone ahead and done this bump. See #72 (comment) for details. |
This modifies the stack install script to be installed on all architectures (although it still likely will fail on sha, but I intend to get those from the error message).
The stack install script has also been moved outside of the docker file for easier future edits. (hence the large amount of deletions).
this also adds support for debian aarch64, solving #59