-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Y-forking import project #10508
Add Y-forking import project #10508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Re adding a test, sounds good too, but I don't quite grasp the question: are you asking whether we'd prefer you to add the test sooner rather than later? Or would the test be transient, because the behaviour would be changed soon? Generally, what are the alternatives you ask for recommendation about?
@Mikolaj, I've added a simple test that the project builds. That should do for now. In future, I hope we can avoid the extra work of importing the same config multiple times and if we decide a project import tree like this, with multiple imports of the same |
Label merge+no rebase is necessary when the pull request is from an organisation. |
Makes sense. Thank you. |
@Mikolaj this hasn't yet merged. |
- We don't check if the same config is imported multiple times
3903526
to
563be04
Compare
Huh, I guess the push made the trick? |
I wasn't expecting it to merge soon after rebasing. I was surprised that it wasn't reporting any problems before the rebase of today, being a week old. The test results were different. I have no idea why the merge was stuck where it was. |
Because Mergify is currently configured to require any |
Thanks @geekosaur for the explanation. |
Split from #9933, this adds just the project used for that pull request's test without adding any test or behaviour change in cabal.