-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data.ByteString.Short.unconsN #525
base: master
Are you sure you want to change the base?
Conversation
Is your implementation of myUnconsN :: Int -> ShortByteString -> Maybe ([Word8], ShortByteString)
myUnconsN n x
| S.length x < n = Nothing
| otherwise = Just (S.unpack y, z)
where
(y, z) = S.splitAt n x |
It seems so:
|
@hasufell could you please rebase? |
Is this PR still needed now that For completeness, I think we'll also end up adding |
It might be that benchmarks after rebase will be more favorable to |
d1896da
to
b475a44
Compare
|
This suggests that |
I guess so |
Fixes #524