Expose Vulkan dynamic rendering #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know enough about the pipeline to understand why the Cachix job failed. Any guidance? Happy to address if I can |
|
@jtnuttall It seems like the CI is being fixed in #201 |
dpwiz
force-pushed
the
feat/dynamic-rendering
branch
from
41ffc9c to
de2fc84
Compare
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes two new properties for the Vulkan implementation:
useDynamicRendering- for use in more modern dynamic rendering pipelinescolorAttachmentFormat- required to enable dynamic renderingRelevant Vulkan docs:
There may be more considerations here, but this seems to work as-is so far as I can tell.