Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extend docs #24

Merged
merged 1 commit into from
Jan 14, 2024
Merged

refactor: extend docs #24

merged 1 commit into from
Jan 14, 2024

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Jan 13, 2024

  • include link to pattern docs
  • show how to exclude a file

README.md Outdated
Comment on lines 170 to 176
1. Add entries to [`CHANGELOG.md`](./CHANGELOG.md) for all changes since the
1. Add entries to [`CHANGELOG.md`](./CHANGELOG.md) for all changes since the
last release.
2. Manually create a GitHub release on
2. Manually create a GitHub release on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this?

action.yml Outdated
@@ -4,8 +4,18 @@ inputs:
pattern:
required: false
description: >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to change this to:

Suggested change
description: >
description: |

README.md Outdated
@@ -142,13 +146,13 @@ versions, but newer (or slightly older) versions may work as well:
Next, clone this repo:

```console
$ git clone [email protected]:haskell-actions/run-fourmolu.git
Copy link
Collaborator

@cdepillabout cdepillabout Jan 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert these three similar changes?

@cdepillabout
Copy link
Collaborator

Thanks, this is a nice improvement!

- include link to pattern docs
- show how to exclude a file
@deemp
Copy link
Contributor Author

deemp commented Jan 14, 2024

Done. Didn't notice a formatter run.

@cdepillabout cdepillabout merged commit 1aa06a7 into haskell-actions:master Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants