fix: Allow WriteOnly attributes to require replacement #36313
+563
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-write-only-required-replace
branch
from
66bbae0 to
468f208
Compare
radeksimko
force-pushed
the
b-write-only-required-replace
branch
3 times, most recently
from
e15d3da to
4bcee80
Compare
radeksimko
force-pushed
the
b-write-only-required-replace
branch
from
4bcee80 to
c5435cd
Compare
SarahFrench
reviewed
Jan 14, 2025
Comment on lines
+2846
to
+2848
| case !writeOnly.Intersection(reqRep).Empty(): | ||
| action = plans.DeleteThenCreate | ||
| actionReason = plans.ResourceInstanceReplaceBecauseCannotUpdate |
There was a problem hiding this comment.
I saw that another switch case here changes the action based on createBeforeDestroy. Should this new switch case also use that to decide which action to use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Release
1.11.x
CHANGELOG entry
WriteOnly attributes are still pre-release.