Fix equivalence test actions #36023
Fix equivalence test actions #36023
Conversation
liamcervante
force-pushed
the
liamcervante/eq-test-fixed
branch
from
4c2f0cc to
670ae80
Compare
liamcervante
force-pushed
the
liamcervante/eq-test-fixed
branch
from
670ae80 to
5fbd174
Compare
| merged = ${{ github.event.pull_request.merged }} | ||
| target_branch = ${{ github.event.pull_request.base.ref }} | ||
| merged=${{ github.event.pull_request.merged }} | ||
| target_branch=${{ github.event.pull_request.base.ref }} |
There was a problem hiding this comment.
We might want to enclose this in (single) quotes in case the branch name has spaces or something that needs escaping.
liamcervante
force-pushed
the
liamcervante/eq-test-fixed
branch
2 times, most recently
from
a80f879 to
b54847b
Compare
|
The equivalence tests will be updated. Please verify the changes here. |
liamcervante
force-pushed
the
liamcervante/eq-test-fixed
branch
from
b54847b to
41f01e6
Compare
|
The equivalence tests will be updated. Please verify the changes here. |
|
The equivalence tests will be updated. Please verify the changes here. |
liamcervante
force-pushed
the
liamcervante/eq-test-fixed
branch
from
6ad6290 to
5fd284c
Compare
|
The equivalence tests will be updated. Please verify the changes here. |
|
The equivalence tests will be updated. Please verify the changes here. |
|
The equivalence tests will be updated. Please verify the changes here. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
| merged = ${{ github.event.pull_request.merged }} | ||
| target_branch = ${{ github.event.pull_request.base.ref }} | ||
| merged="${{ github.event.pull_request.merged }}" | ||
| target_branch="${{ github.event.pull_request.base.ref }}" |
There was a problem hiding this comment.
| target_branch="${{ github.event.pull_request.base.ref }}" | |
| target_branch='${{ github.event.pull_request.base.ref }}' |
I think this is slightly safer as it disallows interpolation, so that in case the ref contained some special characters, like $() then it won't have any special meaning if it's enclosed in ' rather than ". The only special character then becomes just '.
Hopefully GitHub disallows branch names with special characters anyway but better safe than sorry.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR fixes all the syntax errors in my first attempt at this.