Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support provider defined functions #321

Merged
merged 16 commits into from
Mar 26, 2024
Merged

feat: support provider defined functions #321

merged 16 commits into from
Mar 26, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 8, 2024 •
edited
Loading

Resolves #320

@ansgarm ansgarm force-pushed the poc-provider-functions branch from e759db0 to 6713ee1 Compare February 12, 2024 13:43
@ansgarm ansgarm changed the title poc provider functions feat: support provider defined functions Feb 13, 2024
@ansgarm ansgarm force-pushed the poc-provider-functions branch from 10c8b22 to 175ea3b Compare February 13, 2024 13:18
@ansgarm ansgarm marked this pull request as ready for review February 15, 2024 08:26
@ansgarm ansgarm requested a review from a team as a code owner February 15, 2024 08:26
dbanck
dbanck requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most parts. I've left some suggestions

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
schema/convert_json.go Outdated Show resolved Hide resolved
schema/convert_json.go Show resolved Hide resolved
schema/convert_json_test.go Show resolved Hide resolved
schema/convert_json_test.go Outdated Show resolved Hide resolved
schema/functions_merge.go Outdated Show resolved Hide resolved
schema/functions_merge.go Outdated Show resolved Hide resolved
@ansgarm ansgarm mentioned this pull request Feb 21, 2024
Closed
11 tasks
@ansgarm ansgarm requested a review from dbanck March 22, 2024 11:47
@ansgarm ansgarm force-pushed the poc-provider-functions branch from 50a5b33 to 32cab01 Compare March 22, 2024 13:35
ansgarm
ansgarm commented Mar 22, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the poc-provider-functions branch 2 times, most recently from 2983b80 to fdd04de Compare March 22, 2024 13:47
@dbanck dbanck force-pushed the poc-provider-functions branch from fdd04de to c7ec756 Compare March 26, 2024 15:38
@dbanck dbanck merged commit 560df6b into main Mar 26, 2024
5 checks passed
@dbanck dbanck deleted the poc-provider-functions branch March 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for provider-defined functions
2 participants
@ansgarm @dbanck