-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: Waypoint Application Template #778
Conversation
323c434
to
58ff7b3
Compare
internal/provider/waypoint/resource_waypoint_application_template.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/resource_waypoint_application_template.go
Outdated
Show resolved
Hide resolved
- labels still can't be completely removed due to API bug
78b28b2
to
e1f0096
Compare
internal/provider/waypoint/data_source_waypoint_application_template.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/data_source_waypoint_application_template.go
Outdated
Show resolved
Hide resolved
internal/provider/waypoint/resource_waypoint_application_template.go
Outdated
Show resolved
Hide resolved
…mplate.go Co-authored-by: Brian Cain <[email protected]>
…mplate.go Co-authored-by: Brian Cain <[email protected]>
…ate.go Co-authored-by: Brian Cain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment about summary being computed vs required that you should look at before merging but everything else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Let's goooo
@hashicorp/cloud-foundations please take a look when you can, the Waypoint team has approved this |
…cp-sdk-go-0.86.0 * main: New Resource: Waypoint Application Template (#778)
Adds new resource
hcp_waypoint_application_template
.Example config:
(Note that this is a draft while I figure out a test failure)
Tests:
$ make testacc TESTARGS='-run=TestAccWaypoint_Application_Template_basic' ...