Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: Waypoint Application Template #778

Merged
merged 11 commits into from
Mar 13, 2024

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 6, 2024

Adds new resource hcp_waypoint_application_template.
Example config:

resource "hcp_waypoint_application_template" "template" {
  name = "some test app template"
  summary = "some summary for fun"
  terraform_no_code_module = {
    source  = "some source"
    version = "some version"
  }
  terraform_cloud_workspace_details = {
    name                 = "some name"
    terraform_project_id = "some id"
  }
}

(Note that this is a draft while I figure out a test failure)

Tests:

$ make testacc TESTARGS='-run=TestAccWaypoint_Application_Template_basic'

...

@catsby catsby force-pushed the hcp-waypoint-application-template branch from 323c434 to 58ff7b3 Compare March 6, 2024 18:12
internal/provider/provider.go Outdated Show resolved Hide resolved
catsby added 2 commits March 8, 2024 14:17
- labels still can't be completely removed due to API bug
@catsby catsby force-pushed the hcp-waypoint-application-template branch from 78b28b2 to e1f0096 Compare March 8, 2024 20:18
@catsby catsby marked this pull request as ready for review March 8, 2024 21:37
@catsby catsby requested review from a team as code owners March 8, 2024 21:37
@catsby catsby requested a review from HenryEstberg March 11, 2024 13:40
@catsby catsby requested a review from briancain March 12, 2024 17:54
Copy link
Contributor

@HenryEstberg HenryEstberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment about summary being computed vs required that you should look at before merging but everything else looks good.

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Let's goooo

@catsby
Copy link
Contributor Author

catsby commented Mar 12, 2024

@hashicorp/cloud-foundations please take a look when you can, the Waypoint team has approved this

@catsby catsby merged commit 3011bca into main Mar 13, 2024
6 checks passed
@catsby catsby deleted the hcp-waypoint-application-template branch March 13, 2024 14:25
catsby added a commit that referenced this pull request Mar 13, 2024
…cp-sdk-go-0.86.0

* main:
  New Resource: Waypoint Application Template (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants