Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added examples for hcp_waypoint_template #1156

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

kokosnuss
Copy link
Contributor

🛠️ Description

This adds example usages for data-source & resource on hcp_waypoint_template .
We struggled while testing especially with setting the correct value for terraform_no_code_module_source.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:
Did not run acceptance test since this are only doc changes

@kokosnuss kokosnuss requested review from a team as code owners December 18, 2024 20:09
Copy link

hashicorp-cla-app bot commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

@huikang huikang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Given this is an example, approving to unblock the team

Copy link
Contributor

@paladin-devops paladin-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! I was just working on adding examples yesterday and happy to see some be added from you!

@paladin-devops paladin-devops merged commit 4b95de6 into hashicorp:main Dec 19, 2024
6 checks passed
@kokosnuss
Copy link
Contributor Author

kokosnuss commented Dec 19, 2024

Thank you for adding this! I was just working on adding examples yesterday and happy to see some be added from you!

What coincidence 😉 i also could add an example for waypoint application?
Furthermore i could contribute a running example launching an application from a template with an azure no-code module in a tfc project with a tfc project variable set having the azurerm env vars. Let me know if this is interesting and where i should add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants