Fix a panic when creating HVS app or secret

[divyapola5]

🛠️ Description

This change adds in a fix for the bug. There is a panic when creating an app or a secret and this change addresses the issue.

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[maxcoulombe]

The changes look good. I was able to reproduce the panic then when building this branch it fixed my TF project.

I did find another bug that we could fix at the same time or as a follow-up PR - up to you.

If you change the name of a hcp_vault_secrets_secret I'd expect that the secret with the previous name gets deleted and the a secret with the new name gets created. However, the TF provider treats it as an update and creates the new secret while not deleting the previous one. Same if the app name changes, the resource gets duplicated instead of recreated.

I think it can be simply fixed by adding this to the "app_name" and "secret_name" on the hcp_vault_secrets_secret schema.

PlanModifiers: []planmodifier.String{
stringplanmodifier.RequiresReplace(),
},

Does it make sense?

[divyapola5]

The changes look good. I was able to reproduce the panic then when building this branch it fixed my TF project.

I did find another bug that we could fix at the same time or as a follow-up PR - up to you.

If you change the name of a hcp_vault_secrets_secret I'd expect that the secret with the previous name gets deleted and the a secret with the new name gets created. However, the TF provider treats it as an update and creates the new secret while not deleting the previous one. Same if the app name changes, the resource gets duplicated instead of recreated.

I think it can be simply fixed by adding this to the "app_name" and "secret_name" on the hcp_vault_secrets_secret schema.

PlanModifiers: []planmodifier.String{
stringplanmodifier.RequiresReplace(),
},

Does it make sense?

Ah did not know about this. Sure, will put up a new PR for this.