HCP Vault Secrets Generic Integration #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcoulombe
requested review from
raymonstah,
keeefer,
absolutelightning,
aahel and
murali-partha
raymonstah
approved these changes
Dec 11, 2024
maxcoulombe
commented
Dec 12, 2024
|
|
||
| func (r *resourceVaultSecretsIntegration) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) { | ||
| attributes := map[string]schema.Attribute{ | ||
| "provider_type": schema.StringAttribute{ |
There was a problem hiding this comment.
provider_type was used instead of provider since it is a reserved Terraform word.
maxcoulombe
commented
Dec 12, 2024
| Validators: []validator.String{ | ||
| stringvalidator.OneOf(ProviderStrings()...), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
All the fields below are just an aggregation of the provider-specific schemas.
maxcoulombe
commented
Dec 12, 2024
| GcpFederatedWorkloadIdentity: integration.gcpFederatedWorkloadIdentity, | ||
| MongoDbAtlasStaticCredentials: integration.mongoDBAtlasStaticCredentials, | ||
| TwilioStaticCredentials: integration.twilioStaticCredentials, | ||
| }, |
There was a problem hiding this comment.
The API enforces that only exactly one of these is non-nil.
jasonpilz
reviewed
Dec 13, 2024
| @@ -49,6 +50,7 @@ var rotatingSecretsImpl = map[Provider]rotatingSecret{ | |||
| ProviderAWS: &awsRotatingSecret{}, | |||
| ProviderGCP: &gcpRotatingSecret{}, | |||
| ProviderMongoDBAtlas: &mongoDBAtlasRotatingSecret{}, | |||
| "mongodb_atlas": &mongoDBAtlasRotatingSecret{}, // The provider name changed to mongodb-atlas to fit with the HVS API, this is for backwards compatibility | |||
rodrigo-hcp
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
We initially implemented the HVS integrations as separate resources. However, the ecosystem initiative aims to significantly increase our catalog, and a distinct resource per provider won't scale well.
This also sets the stage to more easily support custom-built or community-contributed integrations or credential types in the future.
The implementation leverages the polymorphic API endpoints and follows the more generic resource design used for hcp_vault_secrets_dynamic_secret and hcp_vault_secrets_rotating_secret.
The existing provider-specific integration resources are marked as deprecated so we can eventually phase them out.
🏗️ Acceptance tests
Output from acceptance testing:
I don't have a screenshot for each but all the ACC tests were reworked to use the generic integration resource. All providers are covered and green.