[HCP Vault Secrets] Fix panic on read errors (#751)

* Fix segmentation fault for missing secrets * changelog
hashicorp · Feb 12, 2024 · d58d335 · d58d335
1 parent 6f90dae
commit d58d335
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changelog/751.txt b/.changelog/751.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+Fixing a panic on errors when opening secrets from HCP Vault Secrets.
+```
diff --git a/internal/provider/vaultsecrets/resource_vault_secrets_secret.go b/internal/provider/vaultsecrets/resource_vault_secrets_secret.go
@@ -118,7 +118,7 @@ func (r *resourceVaultsecretsSecret) Create(ctx context.Context, req resource.Cr
 
 	res, err := clients.CreateVaultSecretsAppSecret(ctx, r.client, loc, plan.AppName.ValueString(), plan.SecretName.ValueString(), plan.SecretValue.ValueString())
 	if err != nil {
-		resp.Diagnostics.AddError("Error creating Vault Secrets Secret", err.Error())
+		resp.Diagnostics.AddError("Error creating secret", err.Error())
 		return
 	}
 
@@ -145,7 +145,8 @@ func (r *resourceVaultsecretsSecret) Read(ctx context.Context, req resource.Read
 
 	res, err := clients.OpenVaultSecretsAppSecret(ctx, r.client, loc, state.AppName.ValueString(), state.SecretName.ValueString())
 	if err != nil {
-		resp.Diagnostics.AddError(err.Error(), "Unable to get secret")
+		resp.Diagnostics.AddError(err.Error(), "Error reading secret")
+		return
 	}
 
 	state.SecretValue = types.StringValue(res.Version.Value)