Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permadiff when Access Context Manager returns a different order for ingress / egress rule identities #20794

Conversation

modular-magician
Copy link
Collaborator

Adds a diff suppress func to ignore ordering for identities in ingress / egress rule resources. The order does not matter and sometimes the API changes it.

Addresses #19203 and #20519

accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_dry_run_egress_policy` `egress_from.identities`
accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_dry_run_ingress_policy` `ingress_from.identities`
accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_egress_policy` `egress_from.identities`
accesscontextmanager: fixed permadiff due to reordering on `google_access_context_manager_service_perimeter_ingress_policy` `ingress_from.identities`

Derived from GoogleCloudPlatform/magic-modules#12572

…or ingress / egress rule identities (hashicorp#12572)

Co-authored-by: Charlesleonius <[email protected]>

[upstream:d630fcf6c9ba4d98b4c0fe8afdb34f3ef2c2fb69]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner December 27, 2024 19:47
@modular-magician modular-magician merged commit 19cddf0 into hashicorp:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant