Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_from_api from liveness_probe field in Cloud Run v2 service #18764

Conversation

modular-magician
Copy link
Collaborator

Fix #17468.

Cloud Run doesn't set a default value for liveness probe. Marking liveness_probe field with default_from_api: true was a mistake.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: `liveness_probe` field in `google_cloud_run_v2_service` resource no longer has a default value from API side. Removing this field and applying the change will remove liveness probe from the Cloud Run service.

Derived from GoogleCloudPlatform/magic-modules#11190

… service (hashicorp#11190)

[upstream:1d3de8b021dd519222961bc4f7d37b2b90fb4a50]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 946666c into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Jul 17, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
@modular-magician modular-magician deleted the downstream-pr-1d3de8b021dd519222961bc4f7d37b2b90fb4a50 branch November 16, 2024 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant