Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob file pattern matching support for the excludes attribute. #354

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jul 24, 2024

Resolves: #62
Closes: #57
Closes: #86
Closes: #98

Add glob file pattern matching to the excludes attributes for the archive_file data source and resource. Supports doublestar ** pattern matching with the bmatcuk/doublestar library.

@SBGoods SBGoods requested a review from a team as a code owner July 24, 2024 19:50
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, nice! One suggestion would be to add some acceptance tests for the actual data source/resources in:

  • data_source_archive_file_test.go
  • resource_archive_file_test.go

🚀

internal/provider/zip_archiver.go Outdated Show resolved Hide resolved
@SBGoods SBGoods merged commit cb36702 into main Jul 30, 2024
19 checks passed
@SBGoods SBGoods deleted the SBGoods/glob-support branch July 30, 2024 19:06
@jd-sandk
Copy link

will this be in v2.4.3 and do we know when this will be released?

@SBGoods SBGoods added this to the v2.5.0 milestone Jul 30, 2024
@SBGoods SBGoods mentioned this pull request Jul 30, 2024
@SBGoods
Copy link
Contributor Author

SBGoods commented Jul 30, 2024

Hi @jd-sandk, this PR will be included in v2.5.0 which will be released tomorrow.

@jd-sandk
Copy link

jd-sandk commented Jul 31, 2024

[@SBGoods @austinvalle] Thank you Selena and Austin, and everyone else for their hard work. I ran across: #62 yesterday around 3PM EST, and looked at it as a bit hopeless as it had been open for a really long time. . . I think I left the page and then decided to circle back to add a simple 👍 vote for the issue, and after my browser loaded the page fresh about 5 minutes later, I was very astounded that the issue was now closed and mark completed.

I ran to this page and was very happy to see everything is solved in this PR, and extremely thankful in the timing of this PR, I've never bumped into an issue before and hoped for it to be resolved soon, and actually have that hope fulfilled. Even though this solution probably was in the pipeline and being worked for a long time: to me it felt like instant gratification.

So for that I just want to thank you all again! 🥳🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support glob paths in archive_file data source excludes
3 participants