-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glob file pattern matching support for the excludes
attribute.
#354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, nice! One suggestion would be to add some acceptance tests for the actual data source/resources in:
data_source_archive_file_test.go
resource_archive_file_test.go
🚀
Co-authored-by: Austin Valle <[email protected]>
will this be in |
Hi @jd-sandk, this PR will be included in |
[@SBGoods @austinvalle] Thank you Selena and Austin, and everyone else for their hard work. I ran across: #62 yesterday around 3PM EST, and looked at it as a bit hopeless as it had been open for a really long time. . . I think I left the page and then decided to circle back to add a simple 👍 vote for the issue, and after my browser loaded the page fresh about 5 minutes later, I was very astounded that the issue was now closed and mark completed. I ran to this page and was very happy to see everything is solved in this PR, and extremely thankful in the timing of this PR, I've never bumped into an issue before and hoped for it to be resolved soon, and actually have that hope fulfilled. Even though this solution probably was in the pipeline and being worked for a long time: to me it felt like instant gratification. So for that I just want to thank you all again! 🥳🎉 |
Resolves: #62
Closes: #57
Closes: #86
Closes: #98
Add glob file pattern matching to the
excludes
attributes for thearchive_file
data source and resource. Supports doublestar**
pattern matching with thebmatcuk/doublestar
library.