Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of archives when using exclude_symlink_directories #298

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

bendbennett
Copy link
Contributor

Closes: #296

@bendbennett bendbennett requested a review from a team as a code owner January 15, 2024 10:09
@github-actions github-actions bot added size/L and removed size/M labels Jan 15, 2024
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes LGTM, do we also want to add tests for the resource that received the same changes?

resource_archive_file_test.go

@github-actions github-actions bot added size/XL and removed size/L labels Jan 22, 2024
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 Thank you for the extensive testing coverage for the various scenarios.

@bendbennett bendbennett merged commit f85af3b into main Jan 23, 2024
41 checks passed
@bendbennett bendbennett deleted the bendbennett/issues-296 branch January 23, 2024 10:17
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants