Use deployment watcher if there's a deploy ID #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mongey
force-pushed
the
cm-continue-when-deploy-id
branch
from
2439a12 to
dd0f7f0
Compare
Mongey
force-pushed
the
cm-continue-when-deploy-id
branch
from
008799f to
0cddd2a
Compare
Previously levant would check the template contained an update stanza at the job level, before watching for a service job deployment to complete. With this change, we'll always wait for a deployment to complete. This allows the Nomad server to be the one to determine if the template has a "deployment" rather than levant.
Currently levant panics if there's a failed deployment for a job without an update stanza.
Mongey
force-pushed
the
cm-continue-when-deploy-id
branch
from
f80b31f to
e04dd53
Compare
|
|
This was referenced Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously levant would check the template contained an update stanza at
the job level, before watching for a service job deployment to complete.
With this change, we'll always wait for a deployment to complete. This
allows the Nomad server to be the one to determine if the template has a
"deployment" rather than levant.
Fixes #145