templater: fail rendering if a variable is not set #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the default behaviour of text/template was used which would print the string "<no value>", this could lead to a situation where an job file appears valid but would fail to run
|
Thanks for this @pmcatominey; I will try to find some day to take a proper look and merge/give feedback. |
|
Is it working? |
|
Not sure when this regressed (I assume purposefully), but #308 seems to cover it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the default behaviour of text/template was used which
would print the string "<no value>", this could lead to a situation
where an job file appears valid but would fail to run
Fixes #11