Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAYP-2345] waypoint add-ons definitions create command #38

Conversation

paladin-devops
Copy link
Contributor

@paladin-devops paladin-devops commented Mar 19, 2024

This PR adds the command:

$ hcp waypoint add-ons definitions create

To test this, use the example from the help text for this command.

@paladin-devops paladin-devops self-assigned this Mar 19, 2024
@paladin-devops paladin-devops force-pushed the WAYP-2345-create-add-on-definitions branch 2 times, most recently from a8cbf0e to 1131e7a Compare March 19, 2024 14:57
@paladin-devops paladin-devops requested a review from a team March 19, 2024 19:27
@paladin-devops paladin-devops force-pushed the WAYP-2344-add-on-definitions branch from a0875b5 to eb4bfcf Compare March 20, 2024 20:33
@paladin-devops paladin-devops force-pushed the WAYP-2345-create-add-on-definitions branch from 1131e7a to 1e5cc67 Compare March 20, 2024 20:33
@paladin-devops paladin-devops marked this pull request as ready for review March 21, 2024 15:12
@paladin-devops paladin-devops requested review from a team and removed request for a team March 21, 2024 20:33
@paladin-devops paladin-devops force-pushed the WAYP-2344-add-on-definitions branch from eb4bfcf to 556af8c Compare March 22, 2024 14:32
@paladin-devops paladin-devops requested a review from dadgar as a code owner March 22, 2024 14:32
@paladin-devops paladin-devops force-pushed the WAYP-2345-create-add-on-definitions branch from ac55ce1 to e9459a6 Compare March 22, 2024 14:32
Copy link
Collaborator

@dadgar dadgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog?

@paladin-devops
Copy link
Contributor Author

@dadgar I will add a changelog on the feature branch -> main PR! 😄

@paladin-devops paladin-devops merged commit 5a2cd52 into WAYP-2344-add-on-definitions Mar 25, 2024
2 checks passed
@paladin-devops paladin-devops deleted the WAYP-2345-create-add-on-definitions branch March 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants