Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-changelog support #33

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Add go-changelog support #33

merged 4 commits into from
Mar 19, 2024

Conversation

dadgar
Copy link
Collaborator

@dadgar dadgar commented Mar 14, 2024

Inspired by hashicorp/consul-api-gateway#101

Will merge after the first release is cut and the repository is made public.

@dadgar dadgar requested a review from tobias-hashicorp March 14, 2024 01:55
@dadgar dadgar marked this pull request as ready for review March 14, 2024 01:56
### Output of affected commands:
-->

### Checklist:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the checklist also include a checkmark for "Regenerated screenshot (if new top-level command was added)"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is worth it given how rare it will be relative to all the expected PRs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no reminder it will very likely be forgotten. Having the check-list entry could be a chance to remember it. But maybe it makes more sense to add a comment to here.

@dadgar dadgar merged commit 65ebd7f into main Mar 19, 2024
4 checks passed
@dadgar dadgar deleted the f-changelog branch March 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants