Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HVS - consume stable 2023-11-28 API #197

Merged
merged 7 commits into from
Nov 21, 2024
Merged

HVS - consume stable 2023-11-28 API #197

merged 7 commits into from
Nov 21, 2024

Conversation

keeefer
Copy link
Contributor

@keeefer keeefer commented Nov 20, 2024

🛠️ Description

Bumps sdk version. Change vault secrets 2023-11-28 api from preview to stable.

🔗 Additional Link

🏗️ Local Testing

👍 Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@keeefer keeefer marked this pull request as ready for review November 21, 2024 17:31
@keeefer keeefer requested a review from a team as a code owner November 21, 2024 17:31
averche
averche approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for cleaning this up!

@keeefer keeefer merged commit f1fa1c4 into main Nov 21, 2024
6 checks passed
@keeefer keeefer deleted the hv-1434-bump-sdk branch November 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keeefer @averche