Add method GetAndAdd to LRU Cache #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This needs to be reworked against the locking/eviction changes that were just merged. But will be happy to have it after! |
vasayxtx
force-pushed
the
GetAndAdd-method
branch
from
eb1f8f2 to
6b74291
Compare
|
@jefferai ok, done. Please review. |
jefferai
reviewed
Jan 5, 2021
| @@ -93,6 +93,22 @@ func (c *Cache) Get(key interface{}) (value interface{}, ok bool) { | |||
| return value, ok | |||
| } | |||
|
|
|||
| // GetAndAdd returns the previous key's value from the cache and adds a new one. | |||
| func (c *Cache) GetAndAdd(key, value interface{}) (previous interface{}, ok, evicted bool) { | |||
There was a problem hiding this comment.
Given the changes in simplelru, I think you could do the same here -- instead of copying the function entirely, modify Add above to call GetAndAdd and simply throw away the parameters that aren't a part of the call.
There was a problem hiding this comment.
Ah, yes, it's my bad. Refactored, thanks!
jefferai
reviewed
Jan 5, 2021
vasayxtx
force-pushed
the
GetAndAdd-method
branch
from
6b74291 to
b1235e0
Compare
Yes, you are right, fixed. |
|
@jefferai could you please review and merge if all is ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sometimes it's useful to get value by key and set a new one atomically (like getset in the Redis).