-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of NET-11798: Set APIGateway TLSConfig if unset or empty into release/1.20.x #22076
Merged
NiniOak
merged 6 commits into
release/1.20.x
from
backport/NET-11798_API_Gateway_TLS_Max_Min_Versions_and_CipherSuites_settings_not_respected/optionally-proper-minnow
Jan 16, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/NET-11798_API_Gateway_TLS_Max_Min_Versions_and_CipherSuites_settings_not_respected/optionally-proper-minnow
branch
from
January 15, 2025 17:14
0e44260
to
3daaca2
Compare
github-team-consul-core-pr-approver
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
NiniOak
previously approved these changes
Jan 15, 2025
NiniOak
dismissed stale reviews from github-team-consul-core-pr-approver and themself
via
January 15, 2025 18:00
9d63b08
NiniOak
previously approved these changes
Jan 15, 2025
* NET-11798: Set APIGateway TLSConfig if unset or empty * add changelog * update golden file tests * add missing golden files * Update .changelog/21984.txt Co-authored-by: Nathan Coleman <[email protected]> * remove use of reflect library and check if object is empty instead --------- Co-authored-by: Nathan Coleman <[email protected]>
NiniOak
approved these changes
Jan 15, 2025
NiniOak
requested review from
github-team-consul-core-pr-approver and
NiniOak
January 15, 2025 18:32
sarahalsmiller
approved these changes
Jan 16, 2025
NiniOak
deleted the
backport/NET-11798_API_Gateway_TLS_Max_Min_Versions_and_CipherSuites_settings_not_respected/optionally-proper-minnow
branch
January 16, 2025 17:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21984 to be assessed for backporting due to the inclusion of the label backport/1.20.
🚨
The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
The API Gateway TLS.{Min,Max}Versions and TLS.CipherSuites settings are not applied to API Gateway Listeners. To fix this:
setAPIGatewayTLSConfig
that handles the logic for setting TLS configuration for APIGatewayTesting & Reproduction steps
Tested manually, as follows:
Using this config file
config.hcl
make dev-build
consul agent -dev -config-file consul.hcl
consul connect envoy -gateway api -service my-gateway -register
curl -s 0:19000/config_dump | grep tls_minimum
"tls_minimum_protocol_version": "TLSv1_3"
Links
PR Checklist
Overview of commits