HIP-1056 Add block streams design #9716
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Greene <[email protected]>
edwin-greene
commented
Nov 7, 2024
| ### Block protobuf to mirror node database mapping | ||
|
|
||
| #### Contract Create Transaction | ||
|
|
There was a problem hiding this comment.
More details on the missing entries still to come.
edwin-greene
commented
Nov 7, 2024
| - Add a `BlockStreamTranslator` that will translate a block file into a record file according to the mapping below. | ||
|
|
||
| ### Block protobuf to mirror node database mapping | ||
|
|
There was a problem hiding this comment.
I've created a prototype of a block to record file translator for the contract create transaction. If we'd like to include it I can push it up as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9716 +/- ##
============================================
- Coverage 92.32% 92.23% -0.10%
- Complexity 7413 7628 +215
============================================
Files 911 937 +26
Lines 31050 32117 +1067
Branches 3978 4071 +93
============================================
+ Hits 28667 29622 +955
- Misses 1450 1542 +92
- Partials 933 953 +20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the design for phase one, support for block stream files.
Related issue(s):
Fixes #9573
Notes for reviewer:
Checklist