Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix smoke test after PBJ Changes were merged and rebased #133

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Aug 23, 2024

Description:
Fix smoke test after PBJ Changes were merged and rebased to use new types

Needed to update the singleBlockRequest test to use the new types.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Aug 23, 2024
@AlfredoG87 AlfredoG87 added P1 High priority issue. Required to be completed in the assigned milestone. Tests issue related to enhancing the tests labels Aug 23, 2024
@AlfredoG87 AlfredoG87 modified the milestone: 0.1.0 Aug 23, 2024
@AlfredoG87 AlfredoG87 marked this pull request as ready for review August 23, 2024 21:43
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner August 23, 2024 21:43
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlfredoG87 AlfredoG87 merged commit 587fac2 into main Aug 23, 2024
10 of 14 checks passed
@AlfredoG87 AlfredoG87 deleted the fix-smoke-test branch August 23, 2024 21:44
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f148832) to head (66243f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #133   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       121       121           
===========================================
  Files             21        21           
  Lines            492       492           
  Branches          27        27           
===========================================
  Hits             492       492           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue. Required to be completed in the assigned milestone. Tests issue related to enhancing the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants