Add Volume Delete Test Step #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test step ensuring that volumes are deleted correctly. This test works independent of the timeout since in case the timeout is exceeded the delete operation will already be considered a fail. Thus, if the test step succeeds, the delete would not have timed out. The test step also ensures that the resource is actually removed. related-to: harvester/harvester#6415 Signed-off-by: Moritz Röhrich <[email protected]>
FrankYang0529
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test step ensuring that volumes are deleted correctly. This test works independent of the timeout since in case the timeout is exceeded the delete operation will already be considered a fail. Thus, if the test step succeeds, the delete would not have timed out. The test step also ensures that the resource is actually removed.
The actual delete logic for volumes was already fixed in 55ee9e6 (#103)
related-to: harvester/harvester#6415