Add IPPool and LoadBalancer resources #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ildefons
force-pushed
the
wip/load-balancer
branch
from
1a4686b to
40e9847
Compare
|
@m-ildefons I add the 1.5.0 milestone to the related issues. The change in terraform is not tied to 1.4 or 1.5 since there is no required feature to be implemented on the Harvester side. |
m-ildefons
force-pushed
the
wip/load-balancer
branch
from
e029365 to
87243a7
Compare
m-ildefons
force-pushed
the
wip/load-balancer
branch
from
87243a7 to
8268f8d
Compare
|
would be nice to have that merged 🙏 |
|
This pull request is now in conflict. Could you fix it @m-ildefons? 🙏 |
related-to: harvester/harvester#4813 related-to: harvester/harvester#4814 Signed-off-by: Moritz Röhrich <[email protected]>
Enable tests, add test scaffolding for IPPool resource, speed up compilation Signed-Off-By: Moritz Roehrich <[email protected]>
More functionality, especially around the LoadBalancer resource Signed-off-by: Moritz Röhrich <[email protected]>
Signed-off-by: Moritz Röhrich <[email protected]>
Fix delete procedure for volume resource. Upon deletion, the volume (PVC) does not produce a usable event. Thus watching the K8s resource for state change will never yeild the expected result. As a consequence the Terraform provider will eventually time-out and produce an error. The fix is to watch for a resource state change instead of an event. This will propagate the deletion of the resource appropriately and the Terraform provider will succeed with the deletion. Signed-off-by: Moritz Röhrich <[email protected]>
Fix VM Network and Storage Class tests Signed-off-by: Moritz Röhrich <[email protected]>
Add negative test cases for IPPool and LoadBalancer resources. This ensures that if mandatory parameters are not given, the program exits with an appropriate error. Signed-off-by: Moritz Röhrich <[email protected]>
Add acceptance tests for VirtualMachine labels (tags) and LoadBalancer resources. The labeling/tagging mechnism is crucial for these tests to work, since a LoadBalancer is required by the admission webhook to have at least one VM that matches its selectors. Also improve documentation. Signed-off-by: Moritz Röhrich <[email protected]>
m-ildefons
force-pushed
the
wip/load-balancer
branch
from
8268f8d to
4a845ce
Compare
| name = "service-loadbalancer" | ||
|
|
||
| # This ensures correct ordering for the creation of the resources. | ||
| # The loadbalancer resource will be rejected by the admission webhook, if not |
There was a problem hiding this comment.
This limitation is removed on v1.4.0 Harvester & LB v0.4.*
| github.com/harvester/harvester v1.3.2 | ||
| github.com/harvester/harvester-load-balancer v0.3.0 | ||
| github.com/harvester/harvester-network-controller v0.5.4 |
There was a problem hiding this comment.
As LB v0.3.0 had some known bugs, could we bump to: Harvester v1.4.0 and LB v.0.4.3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS, DO NOT MERGEThis is work in progress for adding IPPool and LoadBalancer resources to the Harvester Terraform provider. These resources are defined in the harvester-load-balancer package.
The goal is to add the ability to manage these resources to the Terraform provider, as well as documentation and tests.
The current status is that most of the data structures and scaffolding is in place, but the functionality is only partially implemented.
related-to: harvester/harvester#4813
related-to: harvester/harvester#4814