Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): deprecated minFreeDiskSpaceGB and add skipGarbageCollectionThresholdCheck #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/upgrade/automatic.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,29 +141,29 @@ Make sure to check [Upgrade support matrix](#upgrade-support-matrix) section fir

## Free system partition space requirement

_Available as of v1.2.0_
_Available as of v1.5.0_

The minimum free system partition space requirement in Harvester v1.2.0 is 30 GiB, which will be revised in each release.
During upgrade, harvester loads images on each node. If the disk usage is more than garbage collection threshold in kubelet, kubelet will delete unused images to free up space. This may break airgapped environment, because the images are not available on the node.

Harvester will check the amount of free system partition space on each node when you select **Upgrade**. If any node does not meet the requirement, the upgrade will be denied as follows
In harvester v1.5.0, we add checks to ensure that each node doesn't trigger garbage collection after loading new images.

![](/img/v1.2/upgrade/upgrade_free_space_check.png)
![](/img/v1.5/upgrade/upgrade_free_space_check.png)

If some nodes do not have enough free system partition space, but you still want to try upgrading, you can customize the upgrade by updating the `harvesterhci.io/minFreeDiskSpaceGB` annotation of `Version` object.
If some nodes do not have enough free system partition space, but you still want to try upgrading, you can customize the upgrade by updating the `harvesterhci.io/skipGarbageCollectionThresholdCheck: true` annotation of `Version` object.

```
apiVersion: harvesterhci.io/v1beta1
kind: Version
metadata:
annotations:
harvesterhci.io/minFreeDiskSpaceGB: "30" # the value is pre-defined and may be customized
name: 1.2.0
brandboat marked this conversation as resolved.
Show resolved Hide resolved
harvesterhci.io/skipGarbageCollectionThresholdCheck: true
name: 1.5.0
namespace: harvester-system
spec:
isoChecksum: <SHA-512 checksum of the ISO>
isoURL: http://192.168.0.181:8000/harvester-master-amd64.iso
minUpgradableVersion: 1.1.2
releaseDate: "20230609"
minUpgradableVersion: 1.4.1
releaseDate: "20250630"
```

:::caution
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading