Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentracing examples #72

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

etsangsplk
Copy link
Contributor

  • instrumented consumer amd producer example with opentracing
    * add doc for jaeger and steps for running opentracing examples
    * add context appropriate
    * add utility for AWS tracing .. Creating tracer/logger etc

Copy link
Owner

@harlow harlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🥇 give me a day or two to test the branch and make sure i don't run into anything odd and then we'll get it merged.

@xzyfer
Copy link

xzyfer commented Dec 11, 2019

Would love to see some progress on this. Happy to help out where possible.

@etsangsplk
Copy link
Contributor Author

etsangsplk commented Dec 15, 2019

@xzyfer

I have stopped development on this. Please take it over. I don't know what's the plan for this. One remaining thing is also for the trace to go through the AWS system, you will very likely to transform the opentracing traceID to X-RAY format. At the time I tested that ion other priejct, it needs to be transformed or else the http header will just got filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants