Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DSVError are not JSON serializable #42

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

CJHwong
Copy link
Member

@CJHwong CJHwong commented Jun 13, 2024

Reason

The recent modifications have led to problems with the Django request process when the DSVError exception is triggered.

Changes

  1. Convert All Python Exceptions to Strings: Transform any Python exceptions into string format before providing the response.
  2. Revert to Original Name if Needed: If dsv_feature.spec_name is not provided, use the original name as a fallback option.

Test Scope

Checks

  • Unit tests are included or not applicable.

@CJHwong CJHwong requested a review from mattwang44 June 13, 2024 04:01
@CJHwong CJHwong merged commit 35fe68e into develop Jun 14, 2024
2 checks passed
@CJHwong CJHwong deleted the fix/dj-err-json-serialization branch June 14, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants