Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring enhancement for providing fingrained erorr messages #41

Merged
merged 8 commits into from
Jun 12, 2024

bump version to 3.4.0

72ca72d
Select commit
Loading
Failed to load commit list.
Merged

Bring enhancement for providing fingrained erorr messages #41

bump version to 3.4.0
72ca72d
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jun 12, 2024 in 0s

1 / 1 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Drop support to Python 3.6 Incomplete
Update pre-commit hooks Incomplete
Implement dsv_feature for specifying spec names Incomplete
Adjust the dsv decorator's behavior for Django requests Incomplete
Unit tests are included or not applicable. Completed
spec name 算是實作的一部份,雖然過去就是如此,我仍不是很確定將 spec name 給 users 看能起到多大的提示作用。我想像中對於 user 來說,能好好顯示欄位位置 (something wrong with a (or nested a.b.c) 好像就夠了,多了一個 user 認不得的 naming 可能還會造成干擾。(但從實作者角度來說多少有幫助,但是單靠 field name 應該還算足夠) Incomplete
(在確定應該要顯示 spec name 的前提下)spec_name attribute 提供了 overwrite "spec name for displaying in error message" 的功能,但是否應該是將 class name 都改成易懂的版本就夠了? Incomplete
(for short-term) 或者說這樣改對於 QA 來說是比較能接受的形式嗎? Incomplete
PEP 3155,可以取出當前物件的完整路徑,困難點在需要去除不少雜訊 Incomplete
在驗證時,同時提供 DSV Spec 的巢狀資訊,困難點在需要大改 DSV 的運作邏輯 Incomplete
不相容 PEP8 Incomplete
若 class member 名稱重複,需要將 nested class 放在 main class 外 Incomplete
LIST Spec 的行為較令人困惑 Incomplete