feat(FIS-8339): FLOAT checker should also accept intgers

hardcoretech · Oct 23, 2024 · df1f22a · df1f22a
1 parent 35fe68e
commit df1f22a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/data_spec_validator/spec/validators.py b/data_spec_validator/spec/validators.py
@@ -211,7 +211,7 @@ class FloatValidator(BaseValidator):
 
     @staticmethod
     def validate(value, extra, data):
-        ok = type(value) is float
+        ok = type(value) is float or type(value) is int
         info = '' if ok else TypeError(f'{repr(value)} is not a float')
         return ok, info
 

diff --git a/test/test_spec.py b/test/test_spec.py
@@ -64,7 +64,10 @@ class FloatSpec:
         ok_data = dict(float_field=3.0)
         assert validate_data_spec(ok_data, FloatSpec)
 
-        nok_data = dict(float_field=3)
+        ok_data = dict(float_field=3)
+        assert validate_data_spec(ok_data, FloatSpec)
+
+        nok_data = dict(float_field='3.0')
         assert is_something_error(TypeError, validate_data_spec, nok_data, FloatSpec)
 
     def test_str(self):