Upgrade rspec and fix warnings #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needed some minor changes due to be_true not working in the same way. Otherwise, all specs still green, although with a number of deprecation warnings which I'll tackle next.
Specs updated automatically using transpec. All specs still green.
The new custom matcher protocol uses `#failure_message` rather than `#failure_message_for_should`.
According to the yard documentation, "Note that the @see tag automatically links its data. You should not use the link syntax in this tag".
These add a number of cool features that are turned off by default for compatibility reasons. For more info, see http://ivoanjo.me/blog/2016/09/25/why-you-should-regenerate-your-spec-helper/
Instead, just prefix top-level rspec methods with RSpec.
rfc6570.rb requires regex_builder.rb which requires rfc6570.rb . To break the cycle, this commit adds a test that only requires rfc6570 if URITemplate::RFC6570 isn't already defined.
rfc6570.rb requires expression.rb which requires rfc6570.rb . To break the cycle, this commit adds a test that only requires rfc6570 if URITemplate::RFC6570 isn't already defined.
Both of these files are indirect dependencies of rfc5670.rb (and are indirectly required by it), so this commit adds a test that these files should only require rfc5670.rb if URITemplate::RFC6570 isn't already defined.
This seems to have been carried over during a refactoring and was actually never used by the current method.
Successfully tested on both jruby 9.1.5.0 and mri 2.3.3 .
Ruby 1.9 has been deprecated for more than two years now, so let's drop it from travis, rather than fighting dependencies to support it.
|
As travis was failing to install the latest versions of some of the test dependencies for 1.9 rubies, I took the liberty of dropping them from the test matrix. Give me a shout if you'd prefer to still support it. |
|
Any news? :) |
BigJ831
approved these changes
Mar 9, 2020
csoto23
approved these changes
May 11, 2021
ghost
deleted a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
All specs still green, and I tested on both mri and jruby! Happy holidays!