fix bugs to run demo #151
Merged
fix bugs to run demo #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
requested review from
nongfushanquan,
amyangfei and
liuzix
and removed request for
amyangfei and
liuzix
| if !task.isEOF { | ||
| task.cancelFn() | ||
| } | ||
| return err | ||
| } | ||
| if reply.IsEof { | ||
| log.L().Info("Reach the end of the file ", zap.Any("fileName:", task.srcDir)) | ||
| task.isEOF = true | ||
| close(task.buffer) |
There was a problem hiding this comment.
if the server crash in the syncing process, the status should be set error
There was a problem hiding this comment.
I think the status assignment is here https://github.com/hanfei1991/microcosm/pull/151/files#diff-d9aaad6e272ef0ddb3d4b3e96e3d52db823421edb128f729d16bac74fcbc1253R87
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
===========================================
Coverage 49.9464% 49.9464%
===========================================
Files 55 55
Lines 4667 4667
===========================================
Hits 2331 2331
+ Misses 2137 2136 -1
- Partials 199 200 +1 |
|
relate #152 |
amyangfei
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, cvsTask can run as expected. In addition: