-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customizing CORS configuration #6981
Support customizing CORS configuration #6981
Conversation
Signed-off-by: JohnNiang <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6981 +/- ##
============================================
+ Coverage 56.99% 57.23% +0.23%
- Complexity 3999 4007 +8
============================================
Files 714 712 -2
Lines 24110 24144 +34
Branches 1585 1590 +5
============================================
+ Hits 13742 13819 +77
+ Misses 9756 9710 -46
- Partials 612 615 +3 ☔ View full report in Codecov by Sentry. |
|
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR adds CorsOptions into SecurityProperties to let users customize their own CORS configuration. e.g.:
Does this PR introduce a user-facing change?