-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add name existence check before creating attachment group and storage policy #6959
feat: add name existence check before creating attachment group and storage policy #6959
Conversation
231ffd8
to
5515dd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢参与贡献,以下是 Review 的改进建议,请有时间看看。
ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentUploadModal.vue
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6959 +/- ##
============================================
+ Coverage 56.99% 57.23% +0.23%
- Complexity 3999 4005 +6
============================================
Files 714 712 -2
Lines 24110 24123 +13
Branches 1585 1588 +3
============================================
+ Hits 13742 13806 +64
+ Misses 9756 9704 -52
- Partials 612 613 +1 ☔ View full report in Codecov by Sentry. |
Hi @LEIYOUSU,感谢参与贡献,有一点非代码层面的建议:
|
Signed-off-by: Ryan Wang <[email protected]>
ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
Outdated
Show resolved
Hide resolved
我优化了一下 i18n,请看 8dda8cd,提交新的改动时,记得 pull 一下。 |
感谢你的耐心指导和建议,我会尽快解决一下 |
@LEIYOUSU 不用关闭 PR 重新提交的,直接继续推送到这个分支即可。 |
ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
Outdated
Show resolved
Hide resolved
ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
在创建附件分组或者存储策略时,支持检查是否有已存在的名称。
Which issue(s) this PR fixes:
Fixes #6946
Special notes for your reviewer:
Does this PR introduce a user-facing change?