Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name existence check before creating attachment group and storage policy #6959

Conversation

LEIYOUSU
Copy link
Contributor

@LEIYOUSU LEIYOUSU commented Oct 28, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

在创建附件分组或者存储策略时,支持检查是否有已存在的名称。

Which issue(s) this PR fixes:

Fixes #6946

Special notes for your reviewer:

Does this PR introduce a user-facing change?

在创建附件分组或者存储策略时,支持检查是否有已存在的名称。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 28, 2024 07:10
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@LEIYOUSU LEIYOUSU force-pushed the feature/avoid-auplicate-grouping-or-strategies branch from 231ffd8 to 5515dd8 Compare October 28, 2024 07:18
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢参与贡献,以下是 Review 的改进建议,请有时间看看。

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (eff73dc) to head (34f10c5).
Report is 43 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6959      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24123      +13     
  Branches       1585     1588       +3     
============================================
+ Hits          13742    13806      +64     
+ Misses         9756     9704      -52     
- Partials        612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 29, 2024
@ruibaby
Copy link
Member

ruibaby commented Oct 29, 2024

Hi @LEIYOUSU,感谢参与贡献,有一点非代码层面的建议:

  1. PR 描述尽可能按照模板的格式,可以看看我帮你修改的。
  2. 已解决的 Change Request 可以点击一下 Resolve conversation 按钮,并请求指定的人重新 Review。

Signed-off-by: Ryan Wang <[email protected]>
@ruibaby
Copy link
Member

ruibaby commented Oct 29, 2024

我优化了一下 i18n,请看 8dda8cd,提交新的改动时,记得 pull 一下。

@ruibaby ruibaby changed the title Feature/avoid auplicate grouping or strategies feat: add name existence check before creating attachment group and storage policy Oct 29, 2024
@LEIYOUSU
Copy link
Contributor Author

感谢你的耐心指导和建议,我会尽快解决一下

@LEIYOUSU LEIYOUSU closed this Oct 29, 2024
@LEIYOUSU LEIYOUSU deleted the feature/avoid-auplicate-grouping-or-strategies branch October 29, 2024 11:17
@LEIYOUSU LEIYOUSU restored the feature/avoid-auplicate-grouping-or-strategies branch October 29, 2024 11:39
@ruibaby
Copy link
Member

ruibaby commented Oct 29, 2024

@LEIYOUSU 不用关闭 PR 重新提交的,直接继续推送到这个分支即可。

@ruibaby ruibaby reopened this Oct 29, 2024
@LEIYOUSU LEIYOUSU requested a review from ruibaby October 29, 2024 13:39
Copy link

sonarcloud bot commented Oct 30, 2024

@LEIYOUSU LEIYOUSU requested a review from ruibaby October 30, 2024 03:18
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2024
Copy link

f2c-ci-robot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 77548ec into halo-dev:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

附件模块中新建存储策略或者分组应该不存在重复相同的分组或者存储策略
3 participants