-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for creating a new group when uploading attachments #6951
feat: add support for creating a new group when uploading attachments #6951
Conversation
Hi @LEIYOUSU ,感谢参与贡献,在合并之前需要签署一下我们的 CLA 协议。 |
另外,看起来有 CI 没过,建议在本地执行一下 https://github.com/halo-dev/halo/actions/runs/11531383268/job/32102020528?pr=6951 |
非常不好意思,由于是第一次进行PR修改,还不太熟悉,这里运行了 |
Quality Gate passedIssues Measures |
没关系,看起来是因为 import 顺序导致的,但这个项目应该会在提交代码之前执行一下 prettier,我不清楚你这边为什么没有自动执行。另外,建议编辑器使用项目内的 Prettier 和 ESLint 规则。 其他地方没有问题,我将合并此 PR,感谢参与贡献~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
============================================
+ Coverage 56.99% 57.23% +0.23%
- Complexity 3999 4005 +6
============================================
Files 714 712 -2
Lines 24110 24123 +13
Branches 1585 1588 +3
============================================
+ Hits 13742 13806 +64
+ Misses 9756 9704 -52
- Partials 612 613 +1 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind improvement
/area ui
/milestone 2.20.x
What this PR does / why we need it:
支持在附件上传界面创建新分组。
Which issue(s) this PR fixes:
Fixes #6942
Special notes for your reviewer:
Does this PR introduce a user-facing change?