Skip to content

Commit

Permalink
Make strings.Title not lowercase acronyms (#1835)
Browse files Browse the repository at this point in the history
Sets the `NoLower` option so that acronyms are not lowercased.
  • Loading branch information
zregvart authored Sep 12, 2023
1 parent 1f0abb3 commit 9ff1457
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion funcs/strings.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func (StringFuncs) TrimSuffix(cutset string, s interface{}) string {

// Title -
func (f *StringFuncs) Title(s interface{}) string {
return cases.Title(f.tag).String(conv.ToString(s))
return cases.Title(f.tag, cases.NoLower).String(conv.ToString(s))
}

// ToUpper -
Expand Down
2 changes: 2 additions & 0 deletions funcs/strings_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ func TestTitle(t *testing.T) {
{`ljoo džar`, `Ljoo Džar`},
{`foo bar᳇baz`, `Foo Bar᳇Baz`}, // ᳇ should be treated as punctuation
{`foo,bar&baz`, `Foo,Bar&Baz`},
{`FOO`, `FOO`},
{`bar FOO`, `Bar FOO`},
}

for _, d := range testdata {
Expand Down

0 comments on commit 9ff1457

Please sign in to comment.