Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diagnostic window. #655

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

DenisPimenov
Copy link
Contributor

Hi @hadashiA !
I have the problem described here #621. I've been looking at the logic for collecting diagnostics and was going to suggest the simple solution, to check the unique scopes with GameObject instanceId.
There is a small problem from using Lookup when building a window. For this I had to add an instanceId to the name of the scope to output to the window.

Also wanted to suggest to add cleaning the scopes from the diagnostics after Dispose/Destroy.

If you have any other suggestions I can fix this solution.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vcontainer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:51am

@hadashiA
Copy link
Owner

Thank you!

However, there was a slight point of concern.
I want the DiagnosticsContext to be able to collect information in a Unity-independent layer. So I don't want to rely too much on the concept of instanceId.
After all, I don't think I need to increase the argument for GetCollector, since the string will still be the key.

I will probably rework that after your commit.
Thanks a lot.

@hadashiA hadashiA mentioned this pull request Apr 12, 2024
@hadashiA hadashiA merged commit 588abdc into hadashiA:master Apr 12, 2024
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants