-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not set config_entry in option flow if HA > 24.11.99 #4181
Conversation
📝 WalkthroughWalkthroughThe changes in the pull request involve modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
custom_components/hacs/config_flow.py
(1 hunks)
🔇 Additional comments (1)
custom_components/hacs/config_flow.py (1)
199-200
: 🧹 Nitpick (assertive)
Verify usage of config_entry in options flow.
The conditional setting of config_entry
could affect functionality if it's used elsewhere in the options flow. Let's verify all usages to ensure no unhandled cases.
Consider adding error handling for cases where config_entry
is not set in newer HA versions, if it's used in any of the class methods.
No longer allowed after home-assistant/core#129562 and home-assistant/developers.home-assistant#2435