Remove netdaemon support #3588
Remove netdaemon support #3588
Conversation
|
Edit: |
emontnemery
force-pushed
the
remove_netdaemon
branch
from
51e4554 to
4158d1d
Compare
emontnemery
added
the
Breaking Change
emontnemery
force-pushed
the
remove_netdaemon
branch
from
7d109f8 to
c89e3c2
Compare
emontnemery
force-pushed
the
remove_netdaemon
branch
from
c89e3c2 to
a572251
Compare
|
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughWalkthroughThe updates focus on the removal of Changes
Sequence Diagram(s)No sequence diagrams are needed as the changes are focused on code cleanup and reformatting without introducing new features or altering existing control flow mechanisms. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (21)
Additional context usedPath-based instructions (3)
Additional comments not posted (17)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
custom_components/hacs/repositories/__init__.py (1)
Line range hint
1-14: Potential oversight:HacsNetdaemonRepositoryremoval not reflected.It appears that the removal of
HacsNetdaemonRepositoryis not reflected in this file. Please verify if this is an oversight and if the repository should indeed be removed from theREPOSITORY_CLASSESdictionary.custom_components/hacs/utils/path.py (1)
Line range hint
9-9: Remove unused import.- from ..base import HacsConfigurationThe import
HacsConfigurationis unused and should be removed to clean up the code.custom_components/hacs/enums.py (1)
Line range hint
1-60: Potential oversight:NETDAEMONenum removal not reflected.It appears that the removal of the
NETDAEMONenum is not reflected in this file. Please verify if this is an oversight and if the enum should indeed be removed.tests/test_config_flow.py (1)
Line range hint
13-13: The import ofHacsBaseis unused and should be removed to clean up the code.- from custom_components.hacs.base import HacsBasetests/conftest.py (1)
Line range hint
5-5: The import ofOrderedDictis unused and should be removed to clean up the code.- from collections import OrderedDicttests/utils/test_validate.py (1)
Line range hint
17-17: Correct the typographical error in the function name.- def test_hacs_manufest_json_schema(): + def test_hacs_manifest_json_schema():tests/output/proxy_calls.json (1)
[!TIP]
Codebase VerificationThe search results indicate that there are still multiple references to
appdaemonin thetests/output/proxy_calls.jsonfile. This suggests that the removal of netdaemon support might not be fully complete, as appdaemon-related entries are still present.
- Lines referencing
appdaemonin various test cases and API calls need to be reviewed and potentially removed or updated to align with the PR's objective of removing netdaemon support.Locations in the codebase that need attention:
tests/helpers/download/test_gather_files_to_download.pytests/repositories/test_download_repository.pytests/repositories/test_remove_repository.pytests/repositories/test_update_repository.pytests/scripts/data/test_generate_category_data.pytests/test_data_client.pytests/test_update.pyAnalysis chain
Line range hint
1-1: Ensure removal of all netdaemon-related entries.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that no netdaemon-related entries exist in the proxy_calls.json file. # Test: Search for 'netdaemon' in the file. Expect: No occurrences. rg --type json 'netdaemon' tests/output/proxy_calls.jsonLength of output: 56
Script:
#!/bin/bash # Description: Verify that no netdaemon-related entries exist in the proxy_calls.json file by searching for additional potential keywords. # Test: Search for 'netdaemon', 'NetDaemon', 'netd', and 'daemon' in the file. Expect: No occurrences. rg --type json 'netdaemon|NetDaemon|netd|daemon' tests/output/proxy_calls.jsonLength of output: 7001
emontnemery
force-pushed
the
remove_netdaemon
branch
from
63c97b2 to
234bd58
Compare
emontnemery
force-pushed
the
remove_netdaemon
branch
from
234bd58 to
cc79d41
Compare
|
@coderabbitai full review |
Remove deprecated netdaemon support