Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing #3357

Merged
merged 125 commits into from
Apr 10, 2024
Merged

Refactor testing #3357

merged 125 commits into from
Apr 10, 2024

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 18, 2023 •
edited by emontnemery
Loading

Note: This PR currently includes #3566, we should probably merge that PR first

Needs #3566 for tests to pass

@ludeeus ludeeus changed the title More testing Refactor testing Dec 29, 2023
emontnemery
emontnemery reviewed Apr 3, 2024
View reviewed changes
tests/common.py Outdated Show resolved Hide resolved
@emontnemery emontnemery marked this pull request as ready for review April 4, 2024 08:58
@emontnemery emontnemery closed this Apr 4, 2024
@emontnemery emontnemery reopened this Apr 4, 2024
@emontnemery emontnemery closed this Apr 4, 2024
@emontnemery emontnemery reopened this Apr 4, 2024
This was referenced Apr 8, 2024
Merged
Merged
Closed
Merged
Merged
Merged
emontnemery
emontnemery reviewed Apr 10, 2024
View reviewed changes
tests/test_config_flow.py Outdated Show resolved Hide resolved
tests/test_data_client.py Outdated Show resolved Hide resolved
tests/test_sensor.py Outdated Show resolved Hide resolved
ludeeus
ludeeus commented Apr 10, 2024
View reviewed changes
Copy link
Member Author

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ symbolic approval as I can not approve my own PR.

emontnemery
emontnemery previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ludeeus ludeeus merged commit 3f09f5f into main Apr 10, 2024
26 checks passed
@ludeeus ludeeus deleted the more-proxy-tests branch April 10, 2024 14:15
@hacs-bot hacs-bot bot added this to the next milestone Apr 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ludeeus @emontnemery